Re: [patch] gdbserver: Add support for Z0/Z1 packets

[Pedro Alves <pedro at codesourcery dot com>]

On Tuesday 23 June 2009 16:17:58, Aleksandar Ristovski wrote:
> Pedro Alves wrote:
> > On Monday 22 June 2009 20:38:50, Aleksandar Ristovski wrote:
> > 
> >>> Z0 and Z1 breakpoints also take a 'len' argument, just
> >>> like Z2-Z4.  You should also pass those down.
> >>>
> >>> But, Let's take a step back --- why not just rename the
> >>> insert_watchpoint|remove_watchpoint functions to insert_point,remove_point,
> >>> and relax the type checks in server.c:

> >> But either way is fine with me - just let me know.
> > 
> > I'd prefer the approach I suggested, and worry about splitting
> > the breakpoints from watchpoints API if/when we actually need it.
> > 
> 
> Ok, then that version is committed.

Well, we had never seen "that" version, and you bypassed
the "rename" suggestion...

Would you care to explain why are watchpoints guarded on
require_running and breakpoints aren't?  It's not super
obvious to me.

> I attached what I committed.
> 
> ChangeLog:
> 
> * server.c (process_serial_event): Add support for Z0 and Z1 
> packet.
> * target.h: Comment for *_watchpoint to make it clear the 
> functions
> can get types '0' and '1'.



-- 
Pedro Alves