This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Fix a reread_symbols regression by mmap [Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.]

From: Paul Pluzhnikov <ppluzhnikov at google dot com>
To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
Cc: Tom Tromey <tromey at redhat dot com>, gdb-patches at sources dot redhat dot com
Date: Tue, 23 Jun 2009 10:35:36 -0700
Subject: Re: [patch] Fix a reread_symbols regression by mmap [Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.]
References: <20090527001157.934BD76BC0@localhost> <8ac60eac0905280956v79d9a84apad9a4370212283b9@mail.gmail.com> <m3vdniw74z.fsf@fleche.redhat.com> <8ac60eac0906101839t4d3978fyc1c6d3b3e2eccb6e@mail.gmail.com> <8ac60eac0906101842y2d2fc9fco331cb4336d9508d0@mail.gmail.com> <m3zlc80yxc.fsf@fleche.redhat.com> <8ac60eac0906161342m67c30151lc7f685e0eb36e41f@mail.gmail.com> <m3y6rrzyi7.fsf@fleche.redhat.com> <8ac60eac0906161407s6498913cu5e50e930d599be77@mail.gmail.com> <20090623150322.GA7654@host0.dyn.jankratochvil.net>

On Tue, Jun 23, 2009 at 8:03 AM, Jan
Kratochvil<jan.kratochvil@redhat.com> wrote:

> while sure your patch is great it has a regression. ?Assuming a regression
> reproducer needs to link GDB with -lmcheck (but did verify it).

The problem also shows up under Valgrind (log attached).

> This patch will fix back (tested on {x86_64,i686}-fedora-linux-gnu):

Looks good to me.

Thanks,
-- 
Paul Pluzhnikov

Attachment: gdb-valgrind.txt
Description: Text document

References:
- Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.
  - From: Paul Pluzhnikov
- Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.
  - From: Paul Pluzhnikov
- Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.
  - From: Tom Tromey
- Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.
  - From: Paul Pluzhnikov
- Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.
  - From: Tom Tromey
- Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.
  - From: Paul Pluzhnikov
- [patch] Fix a reread_symbols regression by mmap [Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.]
  - From: Jan Kratochvil

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]