This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Simplify MI breakpoint setting

On Friday 07 August 2009 Tom Tromey wrote:

> >>>>> "Volodya" == Vladimir Prus <vladimir@codesourcery.com> writes:
> 
> Volodya> Further, set_breakpoint appears to be trivial and useless
> Volodya> wrapper over break_command_really. This patch cleans that
> Volodya> up. Are breakpoint.{c,h} changes OK?
> 
> I think the point of this is not to expose all the parameters of
> break_command_really outside of breakpoint.c.

And, progressing recursively, what is the point of not exposing all the
parameters of break_command_really? set_breakpoint is only ever used
in MI code, and MI code does not mind those 3 extra parameters.

- Volodya
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]