This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: obtaining configure args from config.status
- From: Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: Jan Kratochvil <jan dot kratochvil at redhat dot com>, gdb-patches at sourceware dot org, bonzini at gnu dot org
- Date: Tue, 8 Sep 2009 20:51:36 +0200
- Subject: Re: obtaining configure args from config.status
- References: <20090628183334.GA5401@gmx.de> <20090728181748.GA3134@gmx.de> <20090826151719.GA22276@host0.dyn.jankratochvil.net> <20090826164636.GA15791@ins.uni-bonn.de> <20090826165410.GA28796@host0.dyn.jankratochvil.net> <20090831202938.GC21485@gmx.de> <20090908162826.GA31394@host0.dyn.jankratochvil.net> <20090908182614.GC13584@gmx.de> <m3ws49wacs.fsf@fleche.redhat.com>
* Tom Tromey wrote on Tue, Sep 08, 2009 at 08:38:11PM CEST:
> >>>>> "Ralf" == Ralf Wildenhues writes:
>
> >> eval $(SHELL) $${rootsrc}/testsuite/configure "$$configargs" \
> >> --srcdir=\$${rootsrc}/testsuite \
> >> Other parts of Makefile.in already cannot cope with spaces in $srcdir.
>
> Ralf> True. The quoting also avoids globbing, though, so I've become used to
> Ralf> using it consistently, also because many other packages do cope with
> Ralf> spaces in the absolute directory name, as long as $srcdir is relative
> Ralf> and doesn't contain any spaces. But hey, if it's desired, I'll gladly
> Ralf> change the patch as above.
>
> If it doesn't hurt anything (other than readability), it is ok to leave
> it as you have it.
Yes, it should not hurt. Thanks for the review, applied.