Re: [rfc] Fix Obj-C method calls on 64-bit PowerPC

["Ulrich Weigand" <uweigand at de dot ibm dot com>]

Matt Rice wrote:
> On Mon, Sep 28, 2009 at 9:32 AM, Joel Brobecker <brobecker@adacore.com> wro=
> te:
> >> =A0 =A0 =A0 * eval.c (evaluate_subexp_standard) [OP_OBJC_MSGCALL]: Suppo=
> rt
> >> =A0 =A0 =A0 platforms that use function descriptors. =A0Prefer to use fu=
> nction
> >> =A0 =A0 =A0 pointer types instead of function types.
> >> =A0 =A0 =A0 * linespec.c (decode_objc): Support function descriptors. =
> =A0Fully
> >> =A0 =A0 =A0 initialize SAL result.
> >> =A0 =A0 =A0 * objc-lang.c (find_methods): Support function descriptors.
> >> =A0 =A0 =A0 Do not require function symbol to point to text section.
> >>
> >> =A0 =A0 =A0 * ppc-sysv-tdep.c (ppc64_sysv_abi_push_dummy_call): When cal=
> ling
> >> =A0 =A0 =A0 via a function pointer, use the descriptor it point to.
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0^^^^^ points ;-)
> >
> > Seems fine to me. Given that this fixes SEGVs, we should consider it
> > for inclusion in the 7.0 branch. You might want to ask ratmice@gmail.com
> > to give it a test before installing on 7.0, but I don't think it would
> > buy us much given that you already tested on s390. At least the risk
> > is limited to ObjC.
> 
> I ran this and the tests against cvs head on x86-64
> Additionally I did some tests for things by hand that aren't yet
> covered by the testsuite
> 
> all seemed fine, thanks for looking into this.

Thanks for testing!  I've now checked this in to head and branch.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com