Re: [patch] Allow gdbserver to dynamically lookup libthread_db.so.1

[Paul Pluzhnikov <ppluzhnikov at google dot com>]

On Sun, Oct 4, 2009 at 1:32 PM, Pedro Alves <pedro@codesourcery.com> wrote:

> Thanks much. ?This is close.

Thanks for your comments, I'll address most of them soon.

Quick question:

>> + ?struct process_info_private *proc = current_process()->private;
>
> Missing space before '()'. ?There are other instances of this.

So this is supposed to be:

  struct process_info_private *proc = current_process ()->private;

That A) looks weird and B) contradicts current usage (before the patch):

grep current_process thread-db.c
  struct process_info_private *proc = current_process()->private;
  struct process_info_private *proc = current_process()->private;
  struct process_info_private *proc = current_process()->private;
  struct process_info *proc = current_process ();


Thanks,
-- 
Paul Pluzhnikov