This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] Fix off-by-one error in record.c (record_list_release_first)

From: Jiang Jilin <freephp at gmail dot com>
To: Hui Zhu <teawater at gmail dot com>
Cc: Michael Snyder <msnyder at vmware dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
Date: Tue, 13 Oct 2009 16:28:21 +0800
Subject: Re: [RFA] Fix off-by-one error in record.c (record_list_release_first)
References: <4AD35AB6.2050903@vmware.com> <7d77a27d0910121917w4abfc09cx43e5667393ef9f79@mail.gmail.com> <daef60380910122346x7a0ffc10jcd7ce7f137e9028f@mail.gmail.com>

On Tue, Oct 13, 2009 at 2:46 PM, Hui Zhu <teawater@gmail.com> wrote:
> Thanks Michael and Jilin,
>
> I think the Michael's patch is more spend up. ?Jilin's patch is more
> clear and can handle set_record_insn_max_num.
>
> I suggest we choice speed up. ?Do you think it's OK?

Agree with you. :)

> If we choice it, Michael, could you please add some comments to
> "record_list_release_first" or change it's name to
> "record_list_release_first_without_update_xxx" to make it clear.
> And please update set_record_insn_max_num.
>
> Thanks,
> Hui
>


-- 
Jiang

References:
- [RFA] Fix off-by-one error in record.c (record_list_release_first)
  - From: Michael Snyder
- Re: [RFA] Fix off-by-one error in record.c (record_list_release_first)
  - From: Jiang Jilin
- Re: [RFA] Fix off-by-one error in record.c (record_list_release_first)
  - From: Hui Zhu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]