This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH/ob] Fix argument botch to store_unsigned_integer


Hi,

I am checking in the attached patch which simply corrects the order of arguments to store_unsigned_integer that was botched by this patch (from 2009-07-02):

@@ -8091,7 +8093,7 @@ dwarf2_const_value (struct attribute *at
/* NOTE: cagney/2003-05-09: In-lined store_address call with
it's body - store_unsigned_integer. */
store_unsigned_integer (SYMBOL_VALUE_BYTES (sym), cu_header->addr_size,
- DW_ADDR (attr));
+ DW_ADDR (attr), byte_order);
SYMBOL_CLASS (sym) = LOC_CONST_BYTES;
break;
case DW_FORM_string:


Note that "byte_order" should be the second to last argument, not the last.

I have verified that all other callers of store_unsigned_integer are correct. This is the only flub.

Keith

ChangeLog
2009-10-14  Keith Seitz  <keiths@redhat.com>

	* dwarf2read.c (dwarf2_const_value): Fix order of arguments to
	store_unsigned_integer.

Attachment: store_unsigned_integer-args.patch
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]