This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix for PR gdb/10819

On Thu, Oct 22, 2009 at 10:43 AM, Tom Tromey <tromey@redhat.com> wrote:

> Paul> + ?/* See comment in dwarf2-frame.c:find_cie on why this check
> Paul> + ? ? is necessary. ?*/
>
> I'm not ok with this comment; references like this are fragile because
> the referenced comment may change without anybody knowing to update this
> one.

How about this one then?
Tested on Linux/x86_64, no regressions.

Thanks,
-- 
Paul Pluzhnikov

2009-10-22  Paul Pluzhnikov  <ppluzhnikov@google.com>

     PR gdb/10819
     * dwarf2-frame.c (find_cie): Don't call bsearch on
     empty cie_table.
     * objfiles.c (find_pc_section): Likewise.
     (update_section_map): Don't allocate empty table.

Attachment: gdb-pr10819-20091022-3.txt
Description: Text document

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]