This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFA] little cleanup in allocate_objfile
- From: Tristan Gingold <gingold at adacore dot com>
- To: gdb-patches ml <gdb-patches at sourceware dot org>
- Date: Fri, 23 Oct 2009 14:43:27 +0200
- Subject: [RFA] little cleanup in allocate_objfile
Hi,
did I miss the obvious ? The initial test in allocate_objfile looks
unnecessary and the comment dates back
to mmalloc.
Tristan.
2009-10-23 Tristan Gingold <gingold@adacore.com>
* objfiles.c (allocate_objfile): Remove useless test. Move
declaration of last_one to the block that uses it.
===================================================================
RCS file: /cvs/src/src/gdb/objfiles.c,v
retrieving revision 1.100
diff -u -r1.100 objfiles.c
--- objfiles.c 22 Oct 2009 20:20:27 -0000 1.100
+++ objfiles.c 23 Oct 2009 12:41:31 -0000
@@ -194,24 +194,16 @@
struct objfile *
allocate_objfile (bfd *abfd, int flags)
{
- struct objfile *objfile = NULL;
- struct objfile *last_one = NULL;
+ struct objfile *objfile;
- /* If we don't support mapped symbol files, didn't ask for the file
to be
- mapped, or failed to open the mapped file for some reason, then
revert
- back to an unmapped objfile. */
-
- if (objfile == NULL)
- {
- objfile = (struct objfile *) xmalloc (sizeof (struct objfile));
- memset (objfile, 0, sizeof (struct objfile));
- objfile->psymbol_cache = bcache_xmalloc ();
- objfile->macro_cache = bcache_xmalloc ();
- /* We could use obstack_specify_allocation here instead, but
- gdb_obstack.h specifies the alloc/dealloc functions. */
- obstack_init (&objfile->objfile_obstack);
- terminate_minimal_symbol_table (objfile);
- }
+ objfile = (struct objfile *) xmalloc (sizeof (struct objfile));
+ memset (objfile, 0, sizeof (struct objfile));
+ objfile->psymbol_cache = bcache_xmalloc ();
+ objfile->macro_cache = bcache_xmalloc ();
+ /* We could use obstack_specify_allocation here instead, but
+ gdb_obstack.h specifies the alloc/dealloc functions. */
+ obstack_init (&objfile->objfile_obstack);
+ terminate_minimal_symbol_table (objfile);
objfile_alloc_data (objfile);
@@ -266,6 +258,8 @@
object_files = objfile;
else
{
+ struct objfile *last_one;
+
for (last_one = object_files;
last_one->next;
last_one = last_one->next);