This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] replay bookmarks


On Tue, Nov 3, 2009 at 16:34, Jakob Engblom <jakob@virtutech.com> wrote:
>> > >> Date: Sun, 01 Nov 2009 13:13:24 -0800
>> > >> From: Michael Snyder <msnyder@vmware.com>
>> > >>
>> > >> + ?add_com ("bookmark", class_bookmark, save_bookmark_command, _("\
>> > >> +Set a bookmark.\n\
>> > >
>> > > This is way too short. ?Suggest to expand a bit:
>> > >
>> > > ? Set a bookmark in the inferior's execution history
>> > >
>> > >> + ?add_com ("goto-bookmark", class_bookmark, goto_bookmark_command, _("\
>> > >> +Go to bookmark <n>\n\
>> > >
>> > > Similarly here: such a short description is hardly useful, as it just
>> > > repeats the name of the command.
>> >
>> > How about this?
>>
>> Fine with me.
>>
>> There are a few instances of user messages where the text is not
>> marked by _().
>>
>> Also, we will need an update for the manual, once this is approved.
>
> Also, will this add corresponding operations to gdb-serial? That is necessary to
> get this working for undodb, Simics, and similar remote-exec bookmarkable
> targets. ?I guess that also means VMWare, right?
>

       * remote.c (remote_get_bookmark): New target method.
       (remote_goto_bookmark): New target method.

Is it you looking for?

Thanks,
Hui


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]