This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] replay bookmarks

From: Pedro Alves <pedro at codesourcery dot com>
To: gdb-patches at sourceware dot org
Cc: Michael Snyder <msnyder at vmware dot com>, Hui Zhu <teawater at gmail dot com>, Eli Zaretskii <eliz at gnu dot org>, "glaw at undo-software dot com" <glaw at undo-software dot com>, "jakob at virtutech dot com" <jakob at virtutech dot com>
Date: Thu, 5 Nov 2009 18:44:39 +0000
Subject: Re: [RFA] replay bookmarks
References: <4AEDF9F4.9040207@vmware.com> <daef60380911030034g5e7dd54ay96dc19c451b401ce@mail.gmail.com> <4AF315B5.3070809@vmware.com>

On Thursday 05 November 2009 18:13:09, Michael Snyder wrote:
> Hui Zhu wrote:
> > I try this patch in i386 ubuntu.  It works very good.
> > 
> > Could you add some works in cmd help to talk about "begin" and "end"?
> 
> Added, plus a few more _()'s, per comment from Eli.

Quick comments:

- any chance you could use packet_ok?

- '||'s at beginning of line, not at end.

- You should be bin2hex/hex2bin'ing the strings that are
  being xfered over the wire.

-- 
Pedro Alves

References:
- [RFA] replay bookmarks
  - From: Michael Snyder
- Re: [RFA] replay bookmarks
  - From: Hui Zhu
- Re: [RFA] replay bookmarks
  - From: Michael Snyder

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]