This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[ob/testsuite] Stop virtfunc.exp if the test can not be run
- From: Daniel Jacobowitz <drow at false dot org>
- To: gdb-patches at sourceware dot org
- Date: Fri, 13 Nov 2009 17:27:11 -0500
- Subject: [ob/testsuite] Stop virtfunc.exp if the test can not be run
Last year sometime I was working on a bug in our startup code that was
sensitive to the alignment and size of the rest of the program. So
there wasn't anything wrong with virtfunc.exp, but it happened to get
unlucky... that caused me to notice this wart. If we can not run the
program, then like other test cases, we should bail out instead of
sending commands at the stuck GDB.
Tested on arm-none-eabi and x86_64-linux, checked in.
2009-11-13 Daniel Jacobowitz <dan@codesourcery.com>
* gdb.cp/virtfunc.exp (do_tests): If runto_main fails, give up.
Index: gdb/testsuite/gdb.cp/virtfunc.exp
===================================================================
--- gdb/testsuite/gdb.cp/virtfunc.exp (revision 218690)
+++ gdb/testsuite/gdb.cp/virtfunc.exp (revision 218691)
@@ -247,7 +247,10 @@ proc do_tests {} {
gdb_test "set language c++" "" ""
gdb_test "set width 0" "" ""
- runto_main
+ if ![runto_main] then {
+ perror "couldn't run to breakpoint"
+ return
+ }
test_ptype_of_classes
gdb_breakpoint test_calls
--
Daniel Jacobowitz
CodeSourcery