Re: [patch] Fix for PR gdb/10838

[Paul Pluzhnikov <ppluzhnikov at google dot com>]

2009/11/11 Paul Pluzhnikov <ppluzhnikov@google.com>:

> That was fast :-)

Too fast, as it turns out :-(
I didn't test the gdbserver part, but this patch introduced a
gdbserver crash here:

Program terminated with signal 11, Segmentation fault.

#0  0x0000000000408b75 in look_up_one_symbol (name=0x7f6dc44ee3a2
"__nptl_threads_events", addrp=0x7fffcce720c8) at
../../../src/gdb/gdbserver/remote-utils.c:1374
1374      for (sym = proc->symbol_cache; sym; sym = sym->next)

proc is NULL.
Called from:

#0  0x0000000000408b75 in look_up_one_symbol () at
../../../src/gdb/gdbserver/remote-utils.c:1374
#1  0x000000000041ae0e in ps_pglobal_lookup () at
../../../src/gdb/gdbserver/proc-service.c:68
#2  0x00007f6dc44ed60d in td_ta_clear_event () from /lib/libthread_db.so.1
#3  0x000000000041ac8b in thread_db_free (proc=0x6311a0) at
../../../src/gdb/gdbserver/thread-db.c:773
#4  0x0000000000411b44 in linux_remove_process (process=0x6311a0) at
../../../src/gdb/gdbserver/linux-low.c:267

Attached patch fixes that (tested with gdbserver on Linux/x86_64 this time).
The gdb.mi/mi-non-stop-exit.exp test is still failing (regression
since 2009-10-27), but apparently for a different reason.

Thanks,
-- 
Paul Pluzhnikov


2009-11-13  Paul Pluzhnikov  <ppluzhnikov@google.com>

	* proc-service.c (ps_pglobal_lookup): Handle error return
	* remote-utils.c (look_up_one_symbol): Don't crash if the process is gone.

Attachment: gdbserver-crash-20091113.txt
Description: Text document