This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Allow "disassemble 'Foo::bar(char *)'"

From: Eli Zaretskii <eliz at gnu dot org>
To: Paul Pluzhnikov <ppluzhnikov at google dot com>
Cc: tromey at redhat dot com, schwab at linux-m68k dot org, gdb-patches at sourceware dot org
Date: Sat, 21 Nov 2009 10:35:10 +0200
Subject: Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
References: <20091114001022.A0A0776CDD@ppluzhnikov.mtv.corp.google.com> <m23a4g5fur.fsf@whitebox.home> <8ac60eac0911150916k70ac0f62hf349b0bc21aa58b7@mail.gmail.com> <m3my2mtjhp.fsf@fleche.redhat.com> <8ac60eac0911161028of5f2352lf1857db7a46a94b2@mail.gmail.com> <8ac60eac0911191539w4245739ka6405ba072b79395@mail.gmail.com> <m3pr7d9ket.fsf@fleche.redhat.com> <8ac60eac0911201642y138489ffvab73550bfa72a89d@mail.gmail.com> <20091121005931.GA24143@caradoc.them.org> <8ac60eac0911201708k2c9bc062w9c34765e03b83566@mail.gmail.com>
Reply-to: Eli Zaretskii <eliz at gnu dot org>

> Date: Fri, 20 Nov 2009 17:08:21 -0800
> From: Paul Pluzhnikov <ppluzhnikov@google.com>
> 
> On Fri, Nov 20, 2009 at 4:59 PM, Daniel Jacobowitz <drow@false.org> wrote:
> 
> >> Does this require a NEWS entry (incompatible change to disassemble
> >> command) ?
> >
> > I think yes.
> 
> Thanks, NEWS mention added.

Thanks.  I have only one comment: You say everywhere in the docs that
the 2 arguments should be "separated by comma".  ("Separated by a
comma" would be more correct, English-wise.)  However, the test files
show that the arguments can in fact be separated by a combination of a
comma and whitespace:

> -test_dis "disassem &staticvar &staticvar+1" "staticvar"
> +test_dis "disassem &staticvar, &staticvar+1" "staticvar"

Is my interpretation of the test correct?  If it is, then the
documentation should say that whitespace is allowed around the comma.

Follow-Ups:
- Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
  - From: Paul Pluzhnikov

References:
- [patch] Allow "disassemble 'Foo::bar(char *)'"
  - From: Paul Pluzhnikov
- Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
  - From: Andreas Schwab
- Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
  - From: Paul Pluzhnikov
- Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
  - From: Tom Tromey
- Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
  - From: Paul Pluzhnikov
- Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
  - From: Paul Pluzhnikov
- Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
  - From: Tom Tromey
- Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
  - From: Paul Pluzhnikov
- Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
  - From: Daniel Jacobowitz
- Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
  - From: Paul Pluzhnikov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]