This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [python][patch] Add is_base_class attribute to fields.


On 12/03/2009 03:39 PM, Eli Zaretskii wrote:
>> Date: Thu, 03 Dec 2009 15:09:55 +0000
>> From: Phil Muldoon <pmuldoon@redhat.com>
>> CC: gdb-patches ml <gdb-patches@sourceware.org>
>>
>> I've modified the patch as attached. If Eli does not have any comments or
>> changes to the doc section, this is what I will commit.
> 
> The doco part is okay, except for one issue:
> 
>> +structure.  This attribute is always provided, and is @code{False}
>> +if the field is not a base class of the type on which @code{fields} was
>                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> +called, or if that type was not a C@t{++} class.
>    ^^^^^^
> I think ``the type that is the argument of @code{fields}'' is much
> more clear (unless I misunderstood what you wanted to say).

That's ok with me. I'll adjust and commit.

Cheers,

Phil


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]