This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Pass all symfile flags to sym_read.


On Dec 4, 2009, at 6:00 PM, Tom Tromey wrote:

>>>>>> "Tristan" == Tristan Gingold <gingold@adacore.com> writes:
> 
> Tristan> 2009-12-02  Tristan Gingold  <gingold@adacore.com>
> Tristan> 	* symfile.h (struct sym_fns): Adjust comment on sym_read.
> Tristan> 	* symfile.c (syms_from_objfile): Pass all symfile flags to sym_read.
> Tristan> 	* dbxread.c (dbx_symfile_read): Rename mainline to symfile_flags,
> Tristan> 	adjust header comment.
> Tristan> 	* elfread.c (elf_symfile_read): Ditto.
> Tristan> 	* somread.c (som_symfile_read): Ditto.
> Tristan> 	* xcoffread.c (xcoff_initial_scan): Ditto.
> Tristan> 	* coffread.c (coff_symfile_read): Rename mainline to symfile_flags.
> Tristan> 	* machoread.c (macho_symfile_read): Ditto.
> Tristan> 	* mipsread.c (mipscoff_symfile_read): Ditto.
> 
> This is ok with one little nit fixed...
> 
> Tristan> diff --git a/gdb/symfile.h b/gdb/symfile.h
> [...]
> Tristan> +     file we are reading.  SYMFILE_FLAGS are the flags passed to
> Tristan> +     symbol_fil_add & co.  */
> 
> ... typo in "symbol_file_add".

Thank you for catching that.
Committed with the typo fix.

Tristan.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]