This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] fix tkill_failed gcc warning in gdbserver


On Mon, Dec 21, 2009 at 12:19 PM, Daniel Jacobowitz <drow@false.org> wrote:
> On Mon, Dec 21, 2009 at 12:10:33PM -0800, Doug Evans wrote:
>> Hi.
>>
>> android doesn't have SYS_tkill but it does have __NR_tkill.
>
> Does it have the other SYS_ constants? ?It's a weird omission.
> Anyway, might as well use __NR_tkill unconditionally.

The next question is, does gdbserver need to check for
syscall.h/syscall() like gdb does?
Or can I just replace #ifdef SYS_tkill with #ifdef __NR_tkill.
gdbserver includes sys/syscall.h unconditionally, gdb/linux-nat.c  does not.
gdb also checks for __NR_tkill in a way that works if it were an enum.
Does one need to worry about that case?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]