This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] GDB crash with empty executable name (MinGW)
- From: Tom Tromey <tromey at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 05 Jan 2010 10:44:38 -0700
- Subject: Re: [RFC] GDB crash with empty executable name (MinGW)
- References: <20100102124622.GW548@adacore.com>
- Reply-to: tromey at redhat dot com
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> 2009-01-02 Joel Brobecker <brobecker@adacore.com>
Joel> * source.c (openp): Add assert that parameter string is not NULL.
Joel> if parameter string is an empty string, then return with a failure
Joel> immediately.
Joel> Anyone in favor?
I think it would be fine, but I would recommend putting some info into
the comment explaining why this check was added... just some detail from
your original note.
Tom