This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Disconnected tracing
- From: Tom Tromey <tromey at redhat dot com>
- To: Stan Shebs <stan at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 06 Jan 2010 12:45:33 -0700
- Subject: Re: [PATCH] Disconnected tracing
- References: <4B441D89.6030902@codesourcery.com>
- Reply-to: tromey at redhat dot com
>>>>> "Stan" == Stan Shebs <stan@codesourcery.com> writes:
Stan> This next patch realizes a long-anticipated advantage of tracepoints,
Stan> namely that it should be possible to disconnect GDB from the target
Stan> but leave the trace experiment running, then reconnect later to see if
Stan> anything interesting turned up.
A couple little nits...
Stan> + extern void create_tracepoint_from_upload (int num, enum bptype type,
Stan> + ULONGEST addr);
Could this be in a header? And then the declaration in
remote_get_tracing_state removed?
Maybe this is another of those "will be fixed by the target vector"
oddities.
Stan> + extern void
Stan> + create_tracepoint_from_upload (int num, enum bptype type, ULONGEST addr)
Stan> + {
It is weird to have "extern" on a definition.
Tom