This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch 09/15] PIE: symbol-less (exec-file only) executables
- From: Tom Tromey <tromey at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 08 Jan 2010 16:44:42 -0700
- Subject: Re: [patch 09/15] PIE: symbol-less (exec-file only) executables
- References: <20091109205950.GJ19138@host0.dyn.jankratochvil.net>
- Reply-to: tromey at redhat dot com
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> I do not find it so important but at least exec_bfd should be
Jan> displayed to the user according to the current displacement IMO.
Sounds reasonable.
Jan> + if (bfd_get_section_vma (abfd, asect) <= abfd->start_address
Jan> + && abfd->start_address < bfd_get_section_vma (abfd, asect)
Jan> + + bfd_get_section_size (asect))
The RHS of the "<" needs parens if it is going to be split.
Jan> + printf_filtered (_("\tEntry point: %s\n"),
Jan> + paddress (gdbarch, bfd_get_start_address (abfd)
Jan> + + displacement));
Likewise, parens around the second argument to paddress, or different
splitting.
This is ok with the formatting nits fixed.
Thanks.
Tom