This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch][python] Implement Python lazy strings (PR 10705)
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Phil Muldoon <pmuldoon at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 11 Jan 2010 21:10:17 +0200
- Subject: Re: [patch][python] Implement Python lazy strings (PR 10705)
- References: <4B4746A7.90309@redhat.com> <83vdfca7im.fsf@gnu.org> <4B4B464F.1060405@redhat.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Mon, 11 Jan 2010 15:39:59 +0000
> From: Phil Muldoon <pmuldoon@redhat.com>
> CC: gdb-patches@sourceware.org
>
> Thanks for the review. I've updated the patch in accordance with your
> requests. How does this look?
It's good to go, but please fix one small error in usage of Texinfo:
> +the string type. For further information on encoding in @value{GDBN}
> +please see: @pxref{Character Sets}.
^^^^^^^^^^^^^^^^^^^^^^^^^^^
You want "see @ref{Character Sets}." here. @pxref is for
cross-references that you put in parentheses.
> +@pxref{Types In Python}. This attribute is not writable.
Two spaces, please.
Thanks.