This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/commit] Rename to_can_use_hw_breakpoint -> to_can_use_hw_watchpoint.


> That's not actually true.
[...]

Thanks for the feedback. Sigh: I guess the first thing is to improve
the documentation of this routine...

I would also love to clarify the "other_type" argument. It's just
not obvious what this is about...

> > In fact, the macro wrapping the call to this routine in current_target 
> > is actually named target_can_use_hardware_watchpoint.  This patch renames 
> > this routine in the target_ops vector, as well as all
> > target-specific implementations, to keep things consistent. 
> 
> Yeah.  No real objections from me.  Consistency is good.

Sounds like renaming to use "watchpoint" wouldn't make things any
better, though.  I'm trying to be lazy, as I don't have the resources
right now to start overhauling the h/w watchpoint & breakpoint support.
But I don't know if there is anything that's going to help short of
that.  Perhaps a quick renaming to use "point" instead of "breakpoint"
would make things slightly clearer.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]