This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch for PR 10728


On 01/28/10 13:09, Tom Tromey wrote:
"Chris" == Chris Moller<cmoller@redhat.com> writes:


Chris> + untested psmang.exp

Wrong name here, this occurs a few times.

Oops--the down side of cut'n'paste...


Chris>  +send_gdb "print x->y2 - x->y1\n"
Chris>  +
Chris>  +gdb_expect {

I think we are trying to avoid send_gdb+gdb_expect, as much as possible.
This test can comfortably be written using gdb_test, so do that.

I tried gdb_test to start with, but it didn't seem to be doing the right thing. I just went back to it and it's doing okay now--my original regex was probably screwed up.


Do you want me to send you a new patch? Or just commit it?

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]