This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC/ia64] memory error when reading wrong core file
On Mon, 01 Feb 2010 07:53:28 +0100, Joel Brobecker wrote:
> > Just if there exists catch_errors shouldn't it be used instead of TRY_CATCH?
>
> TRY_CATCH was introduced after catch_error, and I *think* that it was
> intended as a simpler way to call some code while being able to handle
> gdb exceptions.
OK, thanks for the info. The code looks better with TRY_CATCH and the longjmp
magic is there either way.
> That made me wonder, however, why we have 2 routines to do the exception
> printing. There's probably some cleanup we could do, there...
Yes... :-)
> gdb/ChangeLog:
>
> * solib-svr4.c (solib_svr4_r_map): catch and print all exception
> errors while reading the inferior memory, and return zero if
> an exception was raised.
>
> This patch should be strictly equivalent to yours, I believe. I've tested
> it against the testcase described in this thread as well as the rest of
> AdaCore's testsuite.
Retested on RHEL-5.4.ia64 as you asked before.
Thanks,
Jan