This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Add x86 xml files


On Thu, Feb 04, 2010 at 04:00:52PM -0800, H.J. Lu wrote:
> +<!DOCTYPE feature SYSTEM "gdb-target.dtd">
> +<feature name="org.gnu.gdb.i386.core">

In addition to Mark's comments:

* The new features will need to be documented in the manual.  I'd
recommend doing that along with the XML files.

* I can't remember exactly why there are some previously existing
features with the same name and two possible contents.  It seems like
a better idea to call one of these org.gnu.gdb.x86_64.* (or x86-64 or
amd64 or whatever).

Otherwise, it seems fine to me.

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]