This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
FYI: fix big-endian bug with DWARF_VALUE_STACK
- From: Tom Tromey <tromey at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Tue, 23 Feb 2010 09:08:32 -0700
- Subject: FYI: fix big-endian bug with DWARF_VALUE_STACK
- Reply-to: Tom Tromey <tromey at redhat dot com>
I'm checking this in on the trunk and the 7.1 branch.
Jakub noticed a bug with DWARF expressions on big-endian machines.
This is https://bugzilla.redhat.com/show_bug.cgi?id=567251
Built and regtested on x86-64 (compile farm) -- little-endian, of
course, so I also ran the relevant tests on a PPC64 box in the farm.
I do have a test case (see the bugzilla link), but it only works on
PPC64, and it relies on having a very new version of gas, so I did not
include it in the patch.
Tom
2010-02-23 Tom Tromey <tromey@redhat.com>
* dwarf2loc.c (read_pieced_value) <DWARF_VALUE_STACK>: Correctly
handle big-endian values.
(dwarf2_evaluate_loc_desc) <DWARF_VALUE_STACK>: Likewise.
diff --git a/gdb/dwarf2loc.c b/gdb/dwarf2loc.c
index 6679d74..1c4d057 100644
--- a/gdb/dwarf2loc.c
+++ b/gdb/dwarf2loc.c
@@ -298,16 +298,14 @@ read_pieced_value (struct value *v)
case DWARF_VALUE_STACK:
{
- gdb_byte bytes[sizeof (ULONGEST)];
size_t n;
int addr_size = gdbarch_addr_bit (c->arch) / 8;
- store_unsigned_integer (bytes, addr_size,
- gdbarch_byte_order (c->arch),
- p->v.expr.value);
n = p->size;
if (n > addr_size)
n = addr_size;
- memcpy (contents + offset, bytes, n);
+ store_unsigned_integer (contents + offset, n,
+ gdbarch_byte_order (c->arch),
+ p->v.expr.value);
}
break;
@@ -476,19 +474,17 @@ dwarf2_evaluate_loc_desc (struct symbol *var, struct frame_info *frame,
case DWARF_VALUE_STACK:
{
- gdb_byte bytes[sizeof (ULONGEST)];
ULONGEST value = (ULONGEST) dwarf_expr_fetch (ctx, 0);
bfd_byte *contents;
size_t n = ctx->addr_size;
- store_unsigned_integer (bytes, ctx->addr_size,
- gdbarch_byte_order (ctx->gdbarch),
- value);
retval = allocate_value (SYMBOL_TYPE (var));
contents = value_contents_raw (retval);
if (n > TYPE_LENGTH (SYMBOL_TYPE (var)))
n = TYPE_LENGTH (SYMBOL_TYPE (var));
- memcpy (contents, bytes, n);
+ store_unsigned_integer (contents, n,
+ gdbarch_byte_order (ctx->gdbarch),
+ value);
}
break;