This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Make mips-linux signal frame unwinding more robust.
- From: Joel Brobecker <brobecker at adacore dot com>
- To: David Daney <ddaney at caviumnetworks dot com>
- Cc: gdb-patches at sourceware dot org, "Pinski, Andrew" <Andrew dot Pinski at caviumnetworks dot com>
- Date: Thu, 25 Feb 2010 12:47:39 -0500
- Subject: Re: [PATCH] Make mips-linux signal frame unwinding more robust.
- References: <4B82CEC4.2010607@caviumnetworks.com>
> This patch makes gdb follow suit and find the sigcontext_base using
> the signal frame's SP rather than an offset from the trampoline.
Is there a document that explains that the sigcontext structure is
always going to be at the frame's SP?
I don't know mips-linux, but something looked funny to me: You avoid
the use of SIGFRAME_CODE_OFFSET to compute the address where the sigcontext
structure is located, but you still use it to compute the frame base
address (used when building the frame ID). Is the frame base address
still a constant offset from FUNC, or does the frame ID base address
also needs to be changed.
I believe that Daniel J has a good knowledge of mips-linux, and would be
an ideal reviewer. If he doesn't have time, though, I'm OK with approving
a patch for the HEAD branch. For the 7.1 branch, though, I'd rather have
a more knowledgeable opinion.
--
Joel