This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch][python] Merge missing type block functionality
- From: Tom Tromey <tromey at redhat dot com>
- To: Phil Muldoon <pmuldoon at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 25 Feb 2010 11:39:33 -0700
- Subject: Re: [patch][python] Merge missing type block functionality
- References: <20100225171727.GA10788@localhost.localdomain>
- Reply-to: tromey at redhat dot com
>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
Phil> In the recent block, symbol and symbol table merge, I missed some
Phil> functionality in py-type. This patch adds that functionality from the
Phil> archer branch.
Phil> What do you think?
One nit...
Phil> + PyErr_SetString (PyExc_RuntimeError,
Phil> + "second argument must be block");
I think the string should be wrapped in _().
Phil> + PyErr_SetString (PyExc_RuntimeError,
Phil> + "'block' argument must be a Block");
Likewise.
With this change the code bits are ok.
Please put your name in the ChangeLog entry.
Tom