This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [python][patch] Fix 11036


>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> If you examine the runtime, the return here is a valid value, not
Phil> a NULL.  In any case, I think that if read_var returns NULL, then this
Phil> is an error case.  If anyone knows this to be different let me know and
Phil> I can go back to returning None in this case.  To reflect this, if the
Phil> result of read_var is NULL, I raise an exception.  What do you think?

I think this is fine.
I dug through the code a bit and I also couldn't see when read_var_value
would return NULL.  Perhaps it is from before the LOC_COMPUTED case was
changed to set the "optimized out" flag?  (Just a random hypothesis
based on the documentation for symbol_computed_ops::read_variable.)

This patch is ok.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]