This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] linux-dp tweaks for android
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 3 Mar 2010 08:41:23 +0400
- Subject: Re: [RFA] linux-dp tweaks for android
- References: <20100302195512.AD7DA84840@ruffy.mtv.corp.google.com>
> Android doesn't have rand_r, so I'm proposing replacing it with rand.
> I _think_ this part of the change is ok, but I wouldn't mind
> another pair of eyes ...
I think this part is fine too - your call to rand/rand_r is protected
by a mutex, so all calls should be sequential.
> 2010-03-02 Doug Evans <dje@google.com>
>
> testsuite/
> * gdb.threads/linux-dp.c (shared_random): Call rand instead of rand_r.
> * gdb.threads/linux-dp.exp: Compile with gdb_compile_pthreads instead
> of gdb_compile. Add another pattern to match android backtrace.
Looks good to me.
--
Joel