This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] fix thinko in arm-tdep.c arm_stub_unwind_sniffer
- From: Daniel Jacobowitz <dan at codesourcery dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 4 Mar 2010 08:49:35 -0500
- Subject: Re: [RFA] fix thinko in arm-tdep.c arm_stub_unwind_sniffer
- References: <20100304020524.0865B84847@ruffy.mtv.corp.google.com>
On Wed, Mar 03, 2010 at 06:05:23PM -0800, Doug Evans wrote:
> Hi.
>
> Ok to check in?
>
> [The result is a boolean indicating success, so why call
> target_read_memory if in_plt_section failed, and why return non-zero
> if target_read_memory failed?]
No, it's correct. We want to use the stub unwinder if we are in the
PLT. We also want to use the stub unwinder if the PC points at an
unreadable address, because the prologue unwinder would try to read
code from pc. Did this cause a problem?
--
Daniel Jacobowitz
CodeSourcery