This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: PATCH: 2/6: Add AVX support (Update document)
- From: Eli Zaretskii <eliz at gnu dot org>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 05 Mar 2010 12:33:21 +0200
- Subject: Re: PATCH: 2/6: Add AVX support (Update document)
- References: <20100304180219.GA10826@intel.com> <20100304180408.GA10869@intel.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Thu, 4 Mar 2010 10:04:08 -0800
> From: "H.J. Lu" <hongjiu.lu@intel.com>
>
> This patch updates document for AVX support. OK to install?
Is it still relevant?
I will review this anyway, in the hope that it will help you submit
the fixed patch down the way.
> +@item x86:xstate=@var{bytes}:xcr0=@var{value}
> +This feature indicates that @value{GDBN} supports x86 XSAVE extended
It will look prettier in print if you use @sc{xsave} instead of
XSAVE. (The result in the Info manual is the same.)
> +state. @var{bytes} specifies the maximum size in bytes of x86 XSAVE
^^
Two spaces between sentences, please (here and elsewhere in your
patch).
> +extended state @value{GDBN} supports. @var{value} specifies the
> +maximum value of the extended control register 0 (the
> +XFEATURE_ENABLED_MASK register) @value{GDBN} supports. The stub should
XFEATURE_ENABLED_MASK is a C symbol, so it should be in @code.
Thanks.