This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Somewhat sanitize watchpoints with conditions on local expressions


On Thursday 04 March 2010 16:18:59, Pedro Alves wrote:
> 	gdb/
> 	* breakpoint.c (condition_command): Handle watchpoint conditions.
> 	(is_hardware_watchpoint): Add comment.
> 	(is_watchpoint): New.
> 	(update_watchpoint): Don't reparse the watchpoint's condition
> 	unless necessary.
> 	(WP_IGNORE): New.
> 	(watchpoint_check): Use it.
> 	(bpstat_check_watchpoint): Handle it.
> 	(bpstat_check_breakpoint_conditions): Evaluate watchpoint local
> 	conditions in a frame where it makes sense.
> 	(watch_command_1): Store the innermost block of the condition
> 	expression.
> 	(delete_breakpoint): Delete the watchpoint condition expression.
> 	* breakpoint.h (struct bp_location) <cond>: Update comment.
> 	(struct breakpoint): New field `cond_exp_valid_block'.
> 
> 	gdb/testsuite/
> 	* gdb.base/watch-cond.c, gdb.base/watch-cond.exp: New.

I've committed these now.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]