This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFC] Why does ui_out_field_core_addr pad with leading zeroes?
- From: dje at google dot com (Doug Evans)
- To: gdb-patches at sourceware dot org
- Date: Thu, 18 Mar 2010 10:30:15 -0700 (PDT)
- Subject: [RFC] Why does ui_out_field_core_addr pad with leading zeroes?
Hi.
I couldn't find an explanation of *why* ui_out_field_core_addr pads
the address with leading zeroes.
Does anyone know?
2010-03-18 Doug Evans <dje@google.com>
* ui-out.c (ui_out_field_core_addr): Don't pad address with leading
zeroes.
Index: ui-out.c
===================================================================
RCS file: /cvs/src/src/gdb/ui-out.c,v
retrieving revision 1.45
diff -u -p -r1.45 ui-out.c
--- ui-out.c 12 Jan 2010 21:40:24 -0000 1.45
+++ ui-out.c 18 Mar 2010 17:19:07 -0000
@@ -498,12 +498,8 @@ ui_out_field_core_addr (struct ui_out *u
address &= ((CORE_ADDR) 1 << addr_bit) - 1;
/* FIXME: cagney/2002-05-03: Need local_address_string() function
- that returns the language localized string formatted to a width
- based on gdbarch_addr_bit. */
- if (addr_bit <= 32)
- strcpy (addstr, hex_string_custom (address, 8));
- else
- strcpy (addstr, hex_string_custom (address, 16));
+ that returns the language localized string. */
+ strcpy (addstr, hex_string (address));
ui_out_field_string (uiout, fldname, addstr);
}
E.g.
Before:
(gdb) b main
Breakpoint 1 at 0x40049c: file hello.c, line 6.
(gdb) i b
Num Type Disp Enb Address What
1 breakpoint keep y 0x000000000040049c in main at hello.c:6
(gdb)
After:
(gdb) b main
Breakpoint 1 at 0x40049c: file hello.c, line 6.
(gdb) i b
Num Type Disp Enb Address What
1 breakpoint keep y 0x40049c in main at hello.c:6
(gdb)