This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Allow explicit 16 or 32 char in 'x /s'
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 18 Mar 2010 20:25:57 +0200
- Subject: Re: [RFC] Allow explicit 16 or 32 char in 'x /s'
- References: <000f01cac623$2ec3a850$8c4af8f0$%muller@ics-cnrs.unistra.fr> <E1Ns9je-0003cA-V7@fencepost.gnu.org> <001e01cac69a$75167630$5f436290$%muller@ics-cnrs.unistra.fr>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
> Cc: <gdb-patches@sourceware.org>
> Date: Thu, 18 Mar 2010 13:56:42 +0100
>
> > > The patch below allows to
> > > print strings that are made of 16 bit or 32 bit char
> > > using:
> > > 'x /hs ' or 'x /ws ' commands.
> >
> > Thanks. If this patch is accepted, we will need a suitable change for
> > the manual.
>
> How about this change?
It's okay, but it needs a few fixes:
> doc/ChangeLog entry:
>
> 2010-03-18 Pierre Muller <muller@ics.u-strasbg.fr>
>
> * gdbint.texinfo (Examining memory): Update for
gdb.texinfo, not gdbint.texinfo.
> +default unit the next time you use @code{x}. For the @samp{i} format,
^^
Two spaces between sentences (here and elsewhere in your patch).
> +Ue @code{x /hs} to display 16-bit char strings and @code{x /ws} to display
Suggest to rephrase
Use @kbd{x /hs} to display strings made of 16-bid wide characters
and similarly for x/ws.
> +32-bit strings. The next use of @code{x /s} will still display 8-bit
^^^^^
I suggest "again" instead of "still"
Okay with these changes.
Thanks.