This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Allow explicit 16 or 32 char in 'x /s'


> From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
> Cc: <gdb-patches@sourceware.org>
> Date: Thu, 18 Mar 2010 13:56:42 +0100
> 
> > >   The patch below allows to
> > > print strings that are made of 16 bit or 32 bit char
> > > using:
> > > 'x /hs ' or 'x /ws ' commands.
> > 
> > Thanks.  If this patch is accepted, we will need a suitable change for
> > the manual.
> 
> How about this change?

It's okay, but it needs a few fixes:

> doc/ChangeLog entry:
> 
> 2010-03-18  Pierre Muller  <muller@ics.u-strasbg.fr>
> 
>       * gdbint.texinfo (Examining memory): Update for

gdb.texinfo, not gdbint.texinfo.

> +default unit the next time you use @code{x}. For the @samp{i} format,
                                              ^^
Two spaces between sentences (here and elsewhere in your patch).

> +Ue @code{x /hs} to display 16-bit char strings and @code{x /ws} to display

Suggest to rephrase

  Use @kbd{x /hs} to display strings made of 16-bid wide characters

and similarly for x/ws.

> +32-bit strings. The next use of @code{x /s} will still display 8-bit
                                                    ^^^^^
I suggest "again" instead of "still"

Okay with these changes.

Thanks.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]