This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] gdb: fix sparc memcpy fortify error
- From: Mike Frysinger <vapier at gentoo dot org>
- To: gdb-patches at sourceware dot org
- Date: Thu, 18 Mar 2010 22:09:09 -0400
- Subject: [PATCH] gdb: fix sparc memcpy fortify error
Building on an x86_64-linux system with --enable-targets=all fails on the
sparc code with a fortify error:
cc1: warnings being treated as errors
In file included from /usr/include/string.h:640,
from gnulib/string.h:23,
from ../../gdb/gdb_string.h:25,
from ../../gdb/vec.h:25,
from ../../gdb/memattr.h:24,
from ../../gdb/target.h:60,
from ../../gdb/exec.h:23,
from ../../gdb/gdbcore.h:31,
from ../../gdb/sparc-tdep.c:29:
In function 'memcpy',
inlined from 'sparc32_store_return_value' at ../../gdb/sparc-tdep.c:1112,
inlined from 'sparc32_return_value' at ../../gdb/sparc-tdep.c:1170:
/usr/include/bits/string3.h:52: error: call to __builtin___memcpy_chk will
always overflow destination buffer
make: *** [sparc-tdep.o] Error 1
So have the buffer be the max of the lengths used with memcpy().
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
2010-03-18 Mike Frysinger <vapier@gentoo.org>
* gdb/sparc-tdep.c (sparc32_store_return_value): Declare the length
of buf using the "len" variable.
gdb/sparc-tdep.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gdb/sparc-tdep.c b/gdb/sparc-tdep.c
index f129a55..ea0cdd2 100644
--- a/gdb/sparc-tdep.c
+++ b/gdb/sparc-tdep.c
@@ -1101,7 +1101,7 @@ sparc32_store_return_value (struct type *type, struct regcache *regcache,
const gdb_byte *valbuf)
{
int len = TYPE_LENGTH (type);
- gdb_byte buf[8];
+ gdb_byte buf[max(len, 8)];
gdb_assert (!sparc_structure_or_union_p (type));
gdb_assert (!(sparc_floating_p (type) && len == 16));
--
1.7.0.2