This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Fix crash on NULL rl_prompt

From: Pedro Alves <pedro at codesourcery dot com>
To: tromey at redhat dot com
Cc: gdb-patches at sourceware dot org, Jan Kratochvil <jan dot kratochvil at redhat dot com>
Date: Tue, 30 Mar 2010 17:41:20 +0100
Subject: Re: [patch] Fix crash on NULL rl_prompt
References: <20100329234026.GA23895@host0.dyn.jankratochvil.net> <201003301712.20874.pedro@codesourcery.com> <m3eij1ye1x.fsf@fleche.redhat.com>

On Tuesday 30 March 2010 17:22:50, Tom Tromey wrote:
> Pedro> It isn't clear to me your patch isn't doing so, FTR.  It could
> Pedro> have been a readline change only visible when using a more recent
> Pedro> system readline, instead of the version bundled with gdb, for
> Pedro> example.
> 
> The included readline handles rl_prompt == NULL:

Yes, and doesn't leave rl_display_promp as NULL.  But,
how did rl_prompt end up NULL in the first place?  Was GDB running in
batch/non-tty stdin, "set editing off", with readline not setup
at all, and tried to enable the TUI/curses anyway?  That's
what I meant by masking out a bug.

-- 
Pedro Alves

Follow-Ups:
- Re: [patch] Fix crash on NULL rl_prompt
  - From: Jan Kratochvil

References:
- [patch] Fix crash on NULL rl_prompt
  - From: Jan Kratochvil
- Re: [patch] Fix crash on NULL rl_prompt
  - From: Pedro Alves
- Re: [patch] Fix crash on NULL rl_prompt
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]