This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Prec: remove useless line in i386_record_lea_modrm_addr


Checked in.

Thanks,
Hui

On Fri, Apr 2, 2010 at 05:51, Michael Snyder <msnyder@vmware.com> wrote:
> OK.
>
> Hui Zhu wrote:
>>
>> Hi,
>>
>> I remove 2 lines in this function because *addr already set to 0 in
>> the begin of this function.
>>
>> Please help me review it.
>>
>> Thanks,
>> Hui
>>
>> 2010-04-01 ?Hui Zhu ?<teawater@gmail.com>
>>
>> ? ? ? ?* i386-tdep.c (i386_record_lea_modrm_addr): Remove useless
>> ? ? ? ?"*addr = 0".
>>
>>
>> ---
>> ?i386-tdep.c | ? ?8 --------
>> ?1 file changed, 8 deletions(-)
>>
>> --- a/i386-tdep.c
>> +++ b/i386-tdep.c
>> @@ -3000,10 +3000,6 @@ i386_record_lea_modrm_addr (struct i386_
>> ? ? ? ? ? ? ?if (irp->regmap[X86_RECORD_R8_REGNUM] && !havesib)
>> ? ? ? ? ? ? ? ?*addr += irp->addr + irp->rip_offset;
>> ? ? ? ? ? ?}
>> - ? ? ? ? else
>> - ? ? ? ? ? {
>> - ? ? ? ? ? ? *addr = 0;
>> - ? ? ? ? ? }
>> ? ? ? ? ?break;
>> ? ? ? ?case 1:
>> ? ? ? ? ?if (target_read_memory (irp->addr, buf, 1))
>> @@ -3077,10 +3073,6 @@ i386_record_lea_modrm_addr (struct i386_
>> ? ? ? ? ? ? ?irp->rm = 0;
>> ? ? ? ? ? ? ?goto no_rm;
>> ? ? ? ? ? ?}
>> - ? ? ? ? else
>> - ? ? ? ? ? {
>> - ? ? ? ? ? ? *addr = 0;
>> - ? ? ? ? ? }
>> ? ? ? ? ?break;
>> ? ? ? ?case 1:
>> ? ? ? ? ?if (target_read_memory (irp->addr, buf, 1))
>
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]