This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: PATCH: 6/6 [3rd try]: Add AVX support (gdbserver changes)
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GDB <gdb-patches at sourceware dot org>
- Date: Sat, 3 Apr 2010 23:57:47 +0200
- Subject: Re: PATCH: 6/6 [3rd try]: Add AVX support (gdbserver changes)
- References: <20100304180219.GA10826@intel.com> <20100304180408.GA10869@intel.com> <20100304180748.GC10869@intel.com> <20100304180901.GD10869@intel.com> <20100304181003.GE10869@intel.com> <20100306222250.GG21133@intel.com> <20100312172541.GB6643@intel.com> <20100329010935.GA27237@intel.com> <20100330164833.GB13521@intel.com>
On Tue, 30 Mar 2010 18:48:33 +0200, H.J. Lu wrote:
> --- a/gdb/gdbserver/linux-ppc-low.c
> +++ b/gdb/gdbserver/linux-ppc-low.c
> @@ -593,14 +593,14 @@ struct regset_info target_regsets[] = {
> fetch them every time, but still fall back to PTRACE_PEEKUSER for the
> general registers. Some kernels support these, but not the newer
> PPC_PTRACE_GETREGS. */
> - { PTRACE_GETVSXREGS, PTRACE_SETVSXREGS, SIZEOF_VSXREGS, EXTENDED_REGS,
> + { PTRACE_GETVSXREGS, PTRACE_SETVSXREGS, 0, SIZEOF_VSXREGS, EXTENDED_REGS,
> ppc_fill_vsxregset, ppc_store_vsxregset },
> { PTRACE_GETVRREGS, PTRACE_SETVRREGS, SIZEOF_VRREGS, EXTENDED_REGS,
^ missing "0, "
linux-ppc-low.c:599: error: incompatible types when initializing type ‘enum regset_type’ using type ‘void (*)(struct regcache *, void *)’
linux-ppc-low.c:599: warning: initialization from incompatible pointer type
> ppc_fill_vrregset, ppc_store_vrregset },
> - { PTRACE_GETEVRREGS, PTRACE_SETEVRREGS, 32 * 4 + 8 + 4, EXTENDED_REGS,
> + { PTRACE_GETEVRREGS, PTRACE_SETEVRREGS, 0, 32 * 4 + 8 + 4, EXTENDED_REGS,
> ppc_fill_evrregset, ppc_store_evrregset },
> - { 0, 0, 0, GENERAL_REGS, ppc_fill_gregset, NULL },
> - { 0, 0, -1, -1, NULL, NULL }
> + { 0, 0, 0, 0, GENERAL_REGS, ppc_fill_gregset, NULL },
> + { 0, 0, 0, -1, -1, NULL, NULL }
> };
Thanks,
Jan