This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Use vectors in uploaded tracepoints


Joel Brobecker wrote:
1. This is now the third place that has a "char_ptr" typedef for use
with vectors. Is there any reason not to consolidate into one
typedef in defs.h?

Certainly no objection on this end, although the benefits seem to be
pretty small. Perhaps it would make even better sense if we added both
the char_ptr and the vector definition? Would that have any negative
effect in terms of amount of code?

My patch has to add the typedef to a .h file, so there's potential for future annoyance if the typedefs ever collide.


The vector definition is probably harmless, although I'm generally reluctant to rely on the compiler + linker always doing the right thing with masses of static inline functions coming from headers. No doubt people will tell me I'm being paranoid, and the build would *never* fail with a complaint about duplicate symbols. :-)

Stan



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]