Re: [RFA][python] Add program space support

[Eli Zaretskii <eliz at gnu dot org>]

> Date: Wed,  7 Apr 2010 10:32:22 -0700 (PDT)
> From: dje@google.com (Doug Evans)
> 
> This patch adds basic support for program spaces to python.

Thanks.  A few comments to the patch for the manual:

> 	doc/
> 	* gdb.texinfo (Python API): Add progspaces section.
> 	(Selecting Pretty-Printers): Progspace pretty-printers are
> 	searched too.

This lacks an entry for the new section you added.

> +@node Progspaces In Python
> +@subsubsection Progspaces In Python

It is okay to use shorthands in node names, but for the section name
I'd prefer to use "Program Spaces", the full name.  There's no
requirement for the two to be identical.

> +A program space, or ``progspace'', represents a symbolic view
                       ^^^^^^^^^^^^^
Please use @dfn{progspace} here, it is specifically designed for
introducing new terminology.  It produces the same quoted string in
Info as ``..'', but looks prettier in the printed version.

> +A program space, or ``progspace'', represents a symbolic view
> +of an address space.

An @xref here to where program spaces are described would be useful.

> +@findex gdb.current_progspace
> +@defun current_progspace
> +This function returns the program space of the currently selected inferior.

Is this a function or a method?  If the latter, we have @defmethod to
DTRT.

Okay with those changes.

Thanks.