This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] PR 11417
- From: Phil Muldoon <pmuldoon at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches ml <gdb-patches at sourceware dot org>
- Date: Thu, 08 Apr 2010 13:38:26 +0100
- Subject: Re: [patch] PR 11417
- References: <4BB20EC0.10500@redhat.com> <m34ojxwuq0.fsf@fleche.redhat.com> <4BB31ECC.10104@redhat.com> <m3sk77t1y0.fsf@fleche.redhat.com>
On 04/07/2010 09:58 PM, Tom Tromey wrote:
>>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
>
> Phil> + if (self_string->address == 0)
> Phil> + {
> Phil> + PyErr_SetString (PyExc_MemoryError,
> Phil> + "Cannot create a value from NULL");
>
> As Joel pointed out in another thread, this should have _().
>
> This is ok with that change. Thanks.
So committed with that change.
Cheers,
Phil