This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
New ARI regression: RE: src/gdb ChangeLog i387-tdep.c i387-tdep.h
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: <hjl at sourceware dot org>, <gdb-patches at sourceware dot org>
- Date: Fri, 9 Apr 2010 00:01:52 +0200
- Subject: New ARI regression: RE: src/gdb ChangeLog i387-tdep.c i387-tdep.h
- References: <20100407184457.20407.qmail@sourceware.org>
Hi Lu,
Your patch introduces two new regressions:
gdb/i387-tdep.c:1036: regression: abort: Do not use abort, instead use
internal_error; GDB should never abort
gdb/i387-tdep.c:1080: regression: abort: Do not use abort, instead use
internal_error; GDB should never abort
abort is only allowed inside utils.c source.
Could you please change your code accordingly?
Thanks in advance,
Pierre
> -----Message d'origine-----
> De?: gdb-cvs-owner@sourceware.org [mailto:gdb-cvs-owner@sourceware.org]
> De la part de hjl@sourceware.org
> Envoyé?: Wednesday, April 07, 2010 8:45 PM
> À?: gdb-cvs@sourceware.org
> Objet?: src/gdb ChangeLog i387-tdep.c i387-tdep.h
>
> CVSROOT: /cvs/src
> Module name: src
> Changes by: hjl@sourceware.org 2010-04-07 18:44:57
>
> Modified files:
> gdb : ChangeLog i387-tdep.c i387-tdep.h
>
> Log message:
> Support i387 AVX.
>
> 2010-04-07 H.J. Lu <hongjiu.lu@intel.com>
>
> * i387-tdep.c: Include "i386-xstate.h".
> (XSAVE_XSTATE_BV_ADDR): New.
> (xsave_avxh_offset): Likewise.
> (XSAVE_AVXH_ADDR): Likewise.
> (i387_supply_xsave): Likewise.
> (i387_collect_xsave): Likewise.
>
> * i387-tdep.h (I387_NUM_YMM_REGS): New.
> (I387_YMM0H_REGNUM): Likewise.
> (I387_YMMENDH_REGNUM): Likewise.
> (i387_supply_xsave): Likewise.
> (i387_collect_xsave): Likewise.
>
> Patches:
> http://sourceware.org/cgi-
> bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.11583&r2=1.11584
> http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/i387-
> tdep.c.diff?cvsroot=src&r1=1.60&r2=1.61
> http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/i387-
> tdep.h.diff?cvsroot=src&r1=1.24&r2=1.25