Re: PATCH: PR corefiles/11467: amd64 gdb generates corrupted 32bit core file

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Mon, Apr 12, 2010 at 11:23 AM, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
>> Date: Mon, 12 Apr 2010 06:22:25 -0700
>> From: "H.J. Lu" <hongjiu.lu@intel.com>
>>
>> On Sun, Apr 11, 2010 at 01:52:50PM -0700, H.J. Lu wrote:
>> > Hi,
>> >
>> > Thanks for Mark's pointer. Solution is very simple. We just need to
>> > make sure that we call the right fill_gregset for 32bit executable
>> > on both Linux/x86-64 and Linux/i386. ?OK to install?
>> >
>> > Thanks.
>> >
>> >
>>
>> Small update to use tdep->gregset_reg_offset instead of
>> i386_linux_gregset_reg_offset. ?OK to install?
>
> No. ?Like I explained in an earlier mail, we're not supposed to end up
> in fetch_gregset() in the first place.
>

fetch_gregset is always defined and used to fill .reg section in
coredump on Linux/x86. i386-tdep.c has

const struct regset *
i386_regset_from_core_section (struct gdbarch *gdbarch,
                               const char *sect_name, size_t sect_size)
{
  struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);

  if (strcmp (sect_name, ".reg") == 0 && sect_size == tdep->sizeof_gregset)
    {
      if (tdep->gregset == NULL)
        tdep->gregset = regset_alloc (gdbarch, i386_supply_gregset,
                                      i386_collect_gregset);
      return tdep->gregset;
    }

For Linux,  tdep->sizeof_gregset != the size of .reg section. In fact,
they have nothing to do with each other. sizeof_gregset includes
SSE and AVX registers, which have offset == -1 since they aren't
general-purpose registers. I don't believe we should set tdep->gregset
since general-purpose registers is a special case for Linux/x86. They
are handled differently. I don't want to change it.

Please see i386-linux-nat.c for all the details.

Thanks.


-- 
H.J.