This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Fix compilation failure on cygwin due to ncurses macro.
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: 'Pedro Alves' <pedro at codesourcery dot com>, gdb-patches at sourceware dot org
- Date: Thu, 15 Apr 2010 08:52:58 -0700
- Subject: Re: [RFA] Fix compilation failure on cygwin due to ncurses macro.
- References: <003001cadae7$2e639860$8b2ac920$@muller@ics-cnrs.unistra.fr> <20100414155944.GK19194@adacore.com> <000001cadbef$a21bad70$e6530850$@muller@ics-cnrs.unistra.fr> <201004141738.22662.pedro@codesourcery.com> <000601cadc72$e751a330$b5f4e990$@muller@ics-cnrs.unistra.fr>
> Thus it should become:
> /* We need to cast the return value of wstandout to void because
> in 2009/08/29 patch to release "5.7" of ncurses library,
> the wstandout macro expands to code that generates a unused-value
> warning at compilation. */
>
> Is this correct?
Sounds right to me - just one nit: I think it's "an unused-value" rather
than "a unused...".
Suggestion (which you are free to ignore): Would it make sense to define
a new function or macro to have the cast (and therefore the comment) in
only one place?
--
Joel