Re: [PATCH]: gdb: fdpic/frv: fix shared library loading

[Mike Frysinger <vapier at gentoo dot org>]

On Thursday 15 April 2010 11:24:49 Andrew Stubbs wrote:
> On 14/04/10 07:59, Mike Frysinger wrote:
> > While I have no way of testing the FRV, the Blackfin FDPIC code is using
> > this same base in a 100% copy&  paste method since we implemented FDPIC
> > the same way as the FRV guys (I'll address this in the future).  This
> > fix was required in order to handle shared libraries with Blackfin FDPIC
> > properly, and I see no reason why it wouldn't also work for FRV (since
> > the uClibc ldso FDPIC code is the same too and that's really what this
> > is poking).
> 
> I'm currently working on FDPIC support for SH-2A uClinux, so I have been
> poking at this same area myself.
> 
> The FRV code would not work for me out of the box - it's a little too
> FRV specific, so I started work on another copy and paste, but thought
> better of it.
> 
> What I've got now is the bones of a solib-fdpic.c which is intended to
> be architecture independent. This should be possible since, so far, all
> the FDPIC Linux implementations I've seen use the same basic ABI, and
> the SH FDPIC will follow suit.

sad, because ive already done the same thing and it's working for Blackfin 
FDPIC.  but we've implemented FDPIC the same was as FRV.

> The first major departure from solib-frv.c is that I've implemented a
> new qXfer remote protocol packet to retrieve the load maps (a pseudo
> register did not seem like a good plan). This should be target
> independent also - I believe FRV has the same ptrace interface as SH, so
> it should Just Work.

i posted a Linux patch a while ago to move the FDPIC ptrace defines out of the 
arch-specific code and into the common ptrace code.  it was acked by everyone, 
but i guess i need to push andrew to merge it.

i dont have a problem with a pseudo register for the loadmaps ... seems like a 
simple/straightforward way of getting the info rather than having to extend 
the gdb protocol.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.