This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH 1/4] procfs.c: Move find_signalled_thread and find_stop_signal.
- From: Joel Brobecker <brobecker at adacore dot com>
- To: gdb-patches at sourceware dot org
- Date: Tue, 20 Apr 2010 18:49:03 -0400
- Subject: [PATCH 1/4] procfs.c: Move find_signalled_thread and find_stop_signal.
- References: <1271803746-13064-1-git-send-email-brobecker@adacore.com>
These two functions are only used from procfs_make_note_section, which
itself is only defined if:
#if defined (UNIXWARE) || defined (PIOCOPENLWP) || defined (PCAGENT)
So these two functions are unused on mips-irix, and they get flagged
by -Wunused-function. This patch simply moves these functions closer
to the function that uses them, which also has the effect of putting
them inside the same #if block as procfs_make_note_section. Thus
they are defined only when used.
gdb/ChangeLog:
* procfs.c (find_signalled_thread, find_stop_signal): Move
these functions down to define them only when used.
Checked in.
---
gdb/procfs.c | 44 ++++++++++++++++++++++----------------------
1 files changed, 22 insertions(+), 22 deletions(-)
diff --git a/gdb/procfs.c b/gdb/procfs.c
index 6413ed0..0ee72dc 100644
--- a/gdb/procfs.c
+++ b/gdb/procfs.c
@@ -6049,28 +6049,6 @@ procfs_first_available (void)
return pid_to_ptid (procinfo_list ? procinfo_list->pid : -1);
}
-static int
-find_signalled_thread (struct thread_info *info, void *data)
-{
- if (info->stop_signal != TARGET_SIGNAL_0
- && ptid_get_pid (info->ptid) == ptid_get_pid (inferior_ptid))
- return 1;
-
- return 0;
-}
-
-static enum target_signal
-find_stop_signal (void)
-{
- struct thread_info *info =
- iterate_over_threads (find_signalled_thread, NULL);
-
- if (info)
- return info->stop_signal;
- else
- return TARGET_SIGNAL_0;
-}
-
/* =================== GCORE .NOTE "MODULE" =================== */
#if defined (UNIXWARE) || defined (PIOCOPENLWP) || defined (PCAGENT)
/* gcore only implemented on solaris and unixware (so far) */
@@ -6148,6 +6126,28 @@ procfs_corefile_thread_callback (procinfo *pi, procinfo *thread, void *data)
return 0;
}
+static int
+find_signalled_thread (struct thread_info *info, void *data)
+{
+ if (info->stop_signal != TARGET_SIGNAL_0
+ && ptid_get_pid (info->ptid) == ptid_get_pid (inferior_ptid))
+ return 1;
+
+ return 0;
+}
+
+static enum target_signal
+find_stop_signal (void)
+{
+ struct thread_info *info =
+ iterate_over_threads (find_signalled_thread, NULL);
+
+ if (info)
+ return info->stop_signal;
+ else
+ return TARGET_SIGNAL_0;
+}
+
static char *
procfs_make_note_section (bfd *obfd, int *note_size)
{
--
1.6.3.3