This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix Linux/i386 register set size
> Date: Tue, 20 Apr 2010 14:45:19 -0700
> From: "H.J. Lu" <hjl.tools@gmail.com>
>
> On Tue, Apr 20, 2010 at 12:42 PM, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
> > Should be 68. ?Confusion is probably caused by the fact that the note
> > size is 144, and that the amd64 register set is also 144. ?The fact
> > that the GDB gcore produces wrong core files in the 32x64 case doesn't
> > help either.
> >
> > Committed.
> >
> >
> > 2010-04-20 ?Mark Kettenis ?<kettenis@gnu.org>
> >
> > ? ? ? ?* i386-linux-tdep.c (i386_linux_regset_sections): Size of the
> > ? ? ? ?general-purpose register set should be 68 instead of 144.
> > ? ? ? ?(i386_linux_sse_regset_sections): Likewise.
> > ? ? ? ?(i386_linux_avx_regset_sections): Likewise.
> >
> >
>
> On Linux, ".reg" section is a special case. Its size is ignored.
> See linux_nat_do_thread_registers for details. You can set
> it to anything and it doesn't make a difference.
Right. No excuse not the correct the mistake though.