This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PR10179, Add support to set a breakpoint at every function in a file


On 04/23/10 05:28, Eli Zaretskii wrote:
Date: Tue, 20 Apr 2010 22:56:14 -0400
From: Chris Moller<cmoller@redhat.com>
CC: gdb-patches@sourceware.org

--- NEWS	19 Apr 2010 00:48:43 -0000	1.373
+++ NEWS	21 Apr 2010 02:52:34 -0000
@@ -47,6 +47,10 @@
    single `break' command creates multiple breakpoints (e.g.,
    breakpoints on overloaded c++ functions).

+* The `rbreak' command now accepts a filename specification as part of
+ its argument, limiting the functions selected by the regex to those
+ in the specified file.
+

This part is okay.


+ * refcard.tex (Breakpoints and Watchpoints): Added brief
+ description of ilename-qualified rbreak.
                        ^^^^^^^
A typo.

+@item rbreak @var{filename:regex}

This should separate filename and regex, because they are 2 distinct arguments.

@item rbreak @var{filename}:@var{regex}

+If @code{rbreak} is called with a filename qualification, it limits
+the search for functions matching the given regular expression to the
+specified file. This can be used, for example, to set breakponts on
+every function in a given file:

It is a good idea to mention in the text the arguments to the command. Like this:

@item rbreak @var{file}:@var{regex}

   If @code{rbreak} is called with a filename qualification, it limits
   the search for functions matching the given regular expression to the
   specified @var{file}.  This can be used, for example, to set
   breakponts on every function in a given file:

Okay with these changes.

Fixed up and committed. Thanks.


Thanks.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]